Skip to content

[Swift6] Rework query string encoding for all requests#21131

Closed
x-sheep wants to merge 2 commits intoOpenAPITools:masterfrom
x-sheep:swift6-no-qs-encodable
Closed

[Swift6] Rework query string encoding for all requests#21131
x-sheep wants to merge 2 commits intoOpenAPITools:masterfrom
x-sheep:swift6-no-qs-encodable

Conversation

@x-sheep
Copy link
Copy Markdown
Contributor

@x-sheep x-sheep commented Apr 23, 2025

#20997

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@x-sheep x-sheep force-pushed the swift6-no-qs-encodable branch 3 times, most recently from 2352b1d to b2b0a2a Compare April 23, 2025 09:57
@x-sheep x-sheep force-pushed the swift6-no-qs-encodable branch from b2b0a2a to bd2fbee Compare April 24, 2025 12:54
@4brunu
Copy link
Copy Markdown
Contributor

4brunu commented Apr 24, 2025

Hi @x-sheep, thanks for creating this PR.
This PR is way bigger than I was expecting, I was expecting just a few minor changes.
Honestly I'm a bit concerned with the stability of Swift generator, because I found another bug #20997 (comment), and maybe there are still other bugs that we didn't find.
So my top priority now is stabilize the Swift generator.
With this in mind, I'm trying to avoid merge big PR, because big changes can create more instability.

@x-sheep
Copy link
Copy Markdown
Contributor Author

x-sheep commented Apr 24, 2025

Hi 4brunu,

This branch is very far from finished. I currently only have this PR open to experiment, and make use of the Bitrise CI.

I do think that calling encodeToQueryString on every parameter is a bad idea, and I want to replace this with another approach. So the amount of affected files is still going to be pretty large, since all generated functions will be changed.

When I'm ready for feedback, I'll give you a mention.

@x-sheep x-sheep changed the title [Swift6] Remove QueryStringEncodable for models [Swift6] Rework query string encoding for all requests Apr 24, 2025
@x-sheep x-sheep closed this Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants